toor
c93e1fe1bd
Removes the ekko / hermes-web-ui branding from the whole tree and drops eight locale files, so the project presents one name and one language pair. Data compatibility is deliberate, not accidental: DB filenames, the JWT audience, and skill manifest ownership all still recognise their pre-rename values so existing deployments under ~/.hermes-web-ui keep working without a re-login or a re-injection. scripts/harness-check.mjs now scans for the legacy strings and fails the build on any new occurrence, with an explicit allow-list (and reasons) for the compatibility paths that must keep them.
113 lines
4.1 KiB
TypeScript
113 lines
4.1 KiB
TypeScript
import { Readable } from 'stream'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const mkdirMock = vi.hoisted(() => vi.fn())
|
|
const writeFileMock = vi.hoisted(() => vi.fn())
|
|
|
|
vi.mock('fs/promises', async () => {
|
|
const actual = await vi.importActual<typeof import('fs/promises')>('fs/promises')
|
|
return {
|
|
...actual,
|
|
mkdir: mkdirMock,
|
|
writeFile: writeFileMock,
|
|
}
|
|
})
|
|
|
|
vi.mock('../../packages/server/src/services/hermes/hermes-profile', () => ({
|
|
getActiveProfileName: vi.fn(() => 'default'),
|
|
}))
|
|
|
|
vi.mock('../../packages/server/src/services/hermes/upload-paths', () => ({
|
|
getProfileUploadDir: vi.fn((profile: string) => `/tmp/hermes-ui/upload/${profile}`),
|
|
}))
|
|
|
|
function multipartBody(
|
|
boundary: string,
|
|
part: { filename?: string; filenameStar?: string; content: string },
|
|
): Buffer {
|
|
const filename = part.filename ? `; filename="${part.filename}"` : ''
|
|
const filenameStar = part.filenameStar ? `; filename*=UTF-8''${part.filenameStar}` : ''
|
|
return Buffer.from([
|
|
`--${boundary}`,
|
|
`Content-Disposition: form-data; name="file"${filename}${filenameStar}`,
|
|
'Content-Type: text/plain',
|
|
'',
|
|
part.content,
|
|
`--${boundary}--`,
|
|
'',
|
|
].join('\r\n'))
|
|
}
|
|
|
|
function normalizePath(value: unknown): string {
|
|
return String(value).replace(/\\/g, '/')
|
|
}
|
|
|
|
describe('upload controller', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mkdirMock.mockResolvedValue(undefined)
|
|
writeFileMock.mockResolvedValue(undefined)
|
|
})
|
|
|
|
it('stores chat uploads under the request-scoped profile upload directory', async () => {
|
|
const boundary = 'test-boundary'
|
|
const { handleUpload } = await import('../../packages/server/src/controllers/upload')
|
|
const ctx: any = {
|
|
get: vi.fn((header: string) => header === 'content-type' ? `multipart/form-data; boundary=${boundary}` : ''),
|
|
req: Readable.from([multipartBody(boundary, { filename: 'note.txt', content: 'hello' })]),
|
|
state: { profile: { name: 'research' } },
|
|
body: undefined,
|
|
status: 200,
|
|
}
|
|
|
|
await handleUpload(ctx)
|
|
|
|
expect(mkdirMock).toHaveBeenCalledWith('/tmp/hermes-ui/upload/research', { recursive: true })
|
|
expect(writeFileMock).toHaveBeenCalledOnce()
|
|
const [savedPath, data] = writeFileMock.mock.calls[0]
|
|
expect(normalizePath(savedPath)).toMatch(/^\/tmp\/hermes-ui\/upload\/research\/[a-f0-9]+\.txt$/)
|
|
expect(data.toString('utf-8')).toBe('hello')
|
|
expect(ctx.body.files[0]).toMatchObject({ name: 'note.txt', path: savedPath })
|
|
})
|
|
|
|
it('parses boundary parameters and RFC 5987 filenames for chat uploads', async () => {
|
|
const boundary = 'test-boundary'
|
|
const { handleUpload } = await import('../../packages/server/src/controllers/upload')
|
|
const ctx: any = {
|
|
get: vi.fn((header: string) => header === 'content-type'
|
|
? `multipart/form-data; boundary=${boundary}; charset=utf-8`
|
|
: ''),
|
|
req: Readable.from([multipartBody(boundary, { filenameStar: 'daily%20report.txt', content: 'hello' })]),
|
|
state: { profile: { name: 'research' } },
|
|
body: undefined,
|
|
status: 200,
|
|
}
|
|
|
|
await handleUpload(ctx)
|
|
|
|
expect(writeFileMock).toHaveBeenCalledOnce()
|
|
const [savedPath, data] = writeFileMock.mock.calls[0]
|
|
expect(normalizePath(savedPath)).toMatch(/^\/tmp\/hermes-ui\/upload\/research\/[a-f0-9]+\.txt$/)
|
|
expect(data.toString('utf-8')).toBe('hello')
|
|
expect(ctx.body.files[0]).toMatchObject({ name: 'daily report.txt', path: savedPath })
|
|
})
|
|
|
|
it('returns 400 for malformed RFC 5987 filenames', async () => {
|
|
const boundary = 'test-boundary'
|
|
const { handleUpload } = await import('../../packages/server/src/controllers/upload')
|
|
const ctx: any = {
|
|
get: vi.fn((header: string) => header === 'content-type' ? `multipart/form-data; boundary=${boundary}` : ''),
|
|
req: Readable.from([multipartBody(boundary, { filenameStar: 'bad%ZZname.txt', content: 'hello' })]),
|
|
state: { profile: { name: 'research' } },
|
|
body: undefined,
|
|
status: 200,
|
|
}
|
|
|
|
await handleUpload(ctx)
|
|
|
|
expect(ctx.status).toBe(400)
|
|
expect(ctx.body).toEqual({ error: 'Malformed multipart filename' })
|
|
expect(writeFileMock).not.toHaveBeenCalled()
|
|
})
|
|
})
|