hermes-ui/tests/server/model-alias-controller.test.ts

import { beforeEach, describe, expect, it, vi } from 'vitest'

const { mockReadAppConfig, mockWriteAppConfig } = vi.hoisted(() => ({
  mockReadAppConfig: vi.fn(),
  mockWriteAppConfig: vi.fn(),
}))

vi.mock('../../packages/server/src/services/app-config', () => ({
  readAppConfig: mockReadAppConfig,
  writeAppConfig: mockWriteAppConfig,
}))

vi.mock('../../packages/server/src/services/config-helpers', () => ({
  readConfigYaml: vi.fn(),
  writeConfigYaml: vi.fn(),
  fetchProviderModels: vi.fn(),
  buildModelGroups: vi.fn(() => ({ default: '', default_provider: '', groups: [] })),
  PROVIDER_ENV_MAP: {},
}))

vi.mock('../../packages/server/src/shared/providers', () => ({
  buildProviderModelMap: vi.fn(() => ({})),
  PROVIDER_PRESETS: [],
}))

vi.mock('../../packages/server/src/services/hermes/copilot-models', () => ({
  getCopilotModelsDetailed: vi.fn(),
  resolveCopilotOAuthToken: vi.fn(),
}))

vi.mock('../../packages/server/src/db', () => ({
  getDb: vi.fn(),
}))

vi.mock('../../packages/server/src/db/hermes/schemas', () => ({
  MODEL_CONTEXT_TABLE: 'model_context',
}))

import { setModelAlias } from '../../packages/server/src/controllers/hermes/models'

describe('model alias controller', () => {
  beforeEach(() => {
    vi.clearAllMocks()
    mockWriteAppConfig.mockResolvedValue({})
  })

  function createCtx(body: unknown) {
    return {
      request: { body },
      status: 200,
      body: undefined as unknown,
    }
  }

  it('saves a trimmed alias in Web UI app config', async () => {
    mockReadAppConfig.mockResolvedValue({
      modelAliases: {
        deepseek: { old: 'Old Alias' },
      },
    })
    const ctx = createCtx({ provider: 'deepseek', model: 'deepseek-v4-flash', alias: '  Flash Alias  ' })

    await setModelAlias(ctx)

    expect(mockWriteAppConfig).toHaveBeenCalledWith({
      modelAliases: {
        deepseek: {
          old: 'Old Alias',
          'deepseek-v4-flash': 'Flash Alias',
        },
      },
    })
    expect(ctx.body).toEqual({
      success: true,
      model_aliases: {
        deepseek: {
          old: 'Old Alias',
          'deepseek-v4-flash': 'Flash Alias',
        },
      },
    })
  })

  it('deletes an alias when alias is blank and removes empty provider entries', async () => {
    mockReadAppConfig.mockResolvedValue({
      modelAliases: {
        deepseek: { 'deepseek-v4-flash': 'Flash Alias' },
      },
    })
    const ctx = createCtx({ provider: 'deepseek', model: 'deepseek-v4-flash', alias: '   ' })

    await setModelAlias(ctx)

    expect(mockWriteAppConfig).toHaveBeenCalledWith({ modelAliases: {} })
    expect(ctx.body).toEqual({ success: true, model_aliases: {} })
  })

  it('rejects missing provider or model', async () => {
    const ctx = createCtx({ provider: 'deepseek', alias: 'Alias' })

    await setModelAlias(ctx)

    expect(ctx.status).toBe(400)
    expect(ctx.body).toEqual({ error: 'Invalid provider, model, or alias' })
    expect(mockWriteAppConfig).not.toHaveBeenCalled()
  })

  it('stores inherited Object.prototype names as own alias keys', async () => {
    mockReadAppConfig.mockResolvedValue({})
    const ctx = createCtx({ provider: 'toString', model: 'valueOf', alias: 'Safe Alias' })

    await setModelAlias(ctx)

    const written = mockWriteAppConfig.mock.calls[0][0]
    expect(written.modelAliases.toString.valueOf).toBe('Safe Alias')
    expect(Object.prototype.hasOwnProperty.call(written.modelAliases, 'toString')).toBe(true)
    expect(Object.prototype.hasOwnProperty.call(written.modelAliases.toString, 'valueOf')).toBe(true)
  })

  it('rejects reserved object keys to avoid prototype pollution', async () => {
    const ctx = createCtx({ provider: '__proto__', model: 'deepseek-v4-flash', alias: 'Alias' })

    await setModelAlias(ctx)

    expect(ctx.status).toBe(400)
    expect(ctx.body).toEqual({ error: 'Invalid provider or model' })
    expect(mockWriteAppConfig).not.toHaveBeenCalled()
    expect(({} as Record<string, unknown>).deepseek).toBeUndefined()
  })
})