toor/hermes-ui
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
836d0228d25ece235a5bc7f04b7755bb90e4a23b
hermes-ui/docs/harness/pr-review.md
T
toor 1e9ea89d86
Build / build (push) Canceled after 0s
Details
NPM Lockfile Check / npm ci --ignore-scripts (push) Canceled after 0s
Details
Playwright / e2e (push) Canceled after 0s
Details
chore: bootstrap hermes-ui skeleton from 0.6.29 snapshot 
Import the client, server, skills, tests, and build scripts as the starting
point for the rebuild, then trim the surfaces this project does not ship:
Electron desktop packaging, the marketing website, and the ESP32 firmware
tree. CI keeps the web build, e2e, lockfile, release, and Docker workflows.

Rename the package and CLI entry points to hermes-ui, drop the prepare hook so
npm ci no longer triggers a build, and drop the removed tsconfig and nodemon
references. Rewrite AGENTS.md, ARCHITECTURE.md, DEVELOPMENT.md, and the READMEs
so the documented package map and hard rules match this repository.

reference_code/ is ignored: it is a read-only snapshot, not an input to the build.
2026-10-16 10:34:35 +08:00

1.5 KiB
Raw Blame History

PR Self-Review

Use this checklist before pushing or updating a pull request.

Scope

  • The PR title states the behavior being changed.
  • The diff is limited to the requested task and required harness updates.
  • Unrelated formatting or refactors are not bundled into the change.
  • User-facing text has locale coverage.

Architecture

  • Client code uses shared API helpers and existing UI patterns.
  • Server routes stay thin and delegate reusable behavior to controllers/services.
  • Web UI state uses config.appHome or documented helpers.
  • Hermes Agent state and Web UI state remain separate.
  • Subprocess calls use argument arrays instead of shell string construction.

Tests And Validation

  • A focused test was added or updated for behavior changes.
  • Browser-visible flows have e2e coverage when the risk justifies it.
  • npm run harness:check passes.
  • The PR body lists validation commands that actually ran.
  • Known limitations or follow-ups are called out.

Release And CI

  • Workflow changes were checked with npm run harness:check.
  • Release artifact lists stay platform-specific where a matrix target has its own expected output.
  • fail_on_unmatched_files: true is preserved when each matrix target has its own expected artifact list.
  • Package manifest changes have matching lockfile changes when dependencies change.

Before Merge

  • CI is green or failures are explained as unrelated.
  • The branch is mergeable.
  • The PR does not depend on hidden local state, credentials, or uncommitted files.
Reference in New Issue View Git Blame Copy Permalink